Messages in this thread | | | From | David Gow <> | Date | Fri, 18 Aug 2023 06:14:17 +0800 | Subject | Re: [PATCH] kunit: fix struct kunit_attr header |
| |
On Fri, 18 Aug 2023 at 03:15, Rae Moar <rmoar@google.com> wrote: > > Add parameter descriptions to struct kunit_attr header for the > parameters attr_default and print. > > Fixes: 39e92cb1e4a1 ("kunit: Add test attributes API structure") > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202308180127.VD7YRPGa-lkp@intel.com/ > > Signed-off-by: Rae Moar <rmoar@google.com> > ---
LGTM, Thanks.
Reviewed-by: David Gow <davidgow@google.com>
Cheers, -- David
> lib/kunit/attributes.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/kunit/attributes.c b/lib/kunit/attributes.c > index 5e3034b6be99..1b512f7e1838 100644 > --- a/lib/kunit/attributes.c > +++ b/lib/kunit/attributes.c > @@ -30,6 +30,8 @@ enum print_ops { > * attribute value > * @filter: function to indicate whether a given attribute value passes a > * filter > + * @attr_default: default attribute value used during filtering > + * @print: value of enum print_ops to indicate when to print attribute > */ > struct kunit_attr { > const char *name; > > base-commit: 582eb3aeed2d06b122fba95518b84506d3d4ceb9 > -- > 2.42.0.rc1.204.g551eb34607-goog > [unhandled content-type:application/pkcs7-signature] | |