Messages in this thread | | | Date | Thu, 17 Aug 2023 23:24:23 +0200 | Subject | Re: [PATCH] interconnect: qcom: Annotate struct icc_onecell_data with __counted_by | From | Konrad Dybcio <> |
| |
On 17.08.2023 22:42, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct icc_onecell_data. > Additionally, since the element count member must be set before accessing > the annotated flexible array member, move its initialization earlier. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <andersson@kernel.org> > Cc: Konrad Dybcio <konrad.dybcio@linaro.org> > Cc: Georgi Djakov <djakov@kernel.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Signed-off-by: Kees Cook <keescook@chromium.org> > --- Very nice, thanks
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
| |