Messages in this thread | | | Date | Thu, 17 Aug 2023 14:58:01 -0600 | Subject | Re: [PATCH] clk: qcom: clk-spmi-pmic-div: Annotate struct spmi_pmic_div_clk_cc with __counted_by | From | "Gustavo A. R. Silva" <> |
| |
On 8/17/23 14:29, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct spmi_pmic_div_clk_cc. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Bjorn Andersson <andersson@kernel.org> > Cc: Andy Gross <agross@kernel.org> > Cc: Konrad Dybcio <konrad.dybcio@linaro.org> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-clk@vger.kernel.org > Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks -- Gustavo
> --- > drivers/clk/qcom/clk-spmi-pmic-div.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/clk-spmi-pmic-div.c b/drivers/clk/qcom/clk-spmi-pmic-div.c > index f846be285f51..f394031eb0e5 100644 > --- a/drivers/clk/qcom/clk-spmi-pmic-div.c > +++ b/drivers/clk/qcom/clk-spmi-pmic-div.c > @@ -177,7 +177,7 @@ static const struct clk_ops clk_spmi_pmic_div_ops = { > > struct spmi_pmic_div_clk_cc { > int nclks; > - struct clkdiv clks[]; > + struct clkdiv clks[] __counted_by(nclks); > }; > > static struct clk_hw *
| |