Messages in this thread | | | Date | Thu, 17 Aug 2023 12:58:45 -0700 | Subject | Re: [PATCH] powerpc/ps3: refactor strncpy usage | From | Geoff Levand <> |
| |
On 8/16/23 14:39, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > `make_first_field()` should use similar implementation to `make_field()` > due to memcpy having more obvious behavior here. The end result yields > the same behavior as the previous `strncpy`-based implementation > including the NUL-padding.
> diff --git a/arch/powerpc/platforms/ps3/repository.c b/arch/powerpc/platforms/ps3/repository.c > index 205763061a2d..1abe33fbe529 100644 > --- a/arch/powerpc/platforms/ps3/repository.c > +++ b/arch/powerpc/platforms/ps3/repository.c > @@ -73,9 +73,9 @@ static void _dump_node(unsigned int lpar_id, u64 n1, u64 n2, u64 n3, u64 n4,
I tested this on PS3 and it seems to be working OK.
Tested-by: Geoff Levand <geoff@infradead.org>
| |