Messages in this thread | | | Date | Wed, 16 Aug 2023 10:37:36 -0700 | From | Nicolin Chen <> | Subject | Re: [PATCH] iommu/arm-smmu-v3: Add a configurable tlbi_range_max_n_shift for TLBI |
| |
On Wed, Aug 16, 2023 at 02:34:33PM -0300, Jason Gunthorpe wrote: > On Wed, Aug 16, 2023 at 10:09:20AM -0700, Nicolin Chen wrote: > > > This seems convoluted for a uapi, you should just make it > > > 'invalidate_threshold' in bytes or something simpler. > > > > Hmm. That'd be a direct 64-bit size configuration, and very likely > > to be at upper 32-bit range, so I feel the value would be very big > > that might be hard to read. > > hard to read is fine, it is sysfs
OK. I'd just do it in size then.
Thanks Nic
| |