Messages in this thread | | | From | Paul Moore <> | Date | Wed, 16 Aug 2023 09:38:02 -0400 | Subject | Re: [PATCH v1] kernel: Add space before parenthesis and around '=', "==" and '<' |
| |
On Tue, Aug 15, 2023 at 10:55 PM Atul Kumar Pant <atulpant.linux@gmail.com> wrote: > On Tue, Aug 15, 2023 at 06:09:19PM -0400, Paul Moore wrote: > > On Aug 15, 2023 Atul Kumar Pant <atulpant.linux@gmail.com> wrote: > > > > > > Fixes following checkpatch.pl issue: > > > ERROR: space required before the open parenthesis '(' > > > ERROR: spaces required around that '=' > > > ERROR: spaces required around that '<' > > > ERROR: spaces required around that '==' > > > > > > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com> > > > --- > > > kernel/acct.c | 2 +- > > > kernel/auditfilter.c | 16 ++++++++-------- > > > kernel/auditsc.c | 2 +- > > > 3 files changed, 10 insertions(+), 10 deletions(-) > > > > I changed the subject line to "audit: add space before parenthesis and > > around '=', "==", and '<'" as the "audit:" prefix is more appropriate > > and I'm a believer of the Oxford Comma. Otherwise it looks fine and I > > just merged it into audit/next, thanks. > > Thank you for your comments. Do I need to change commit message now?
No, I fixed it up and merged the patch, it's just something to remember for future patch submissions. Here is the commit in the audit/next branch:
commit 62acadda115a94bffd1f6b36acbb67e3f04811be Author: Atul Kumar Pant <atulpant.linux@gmail.com> Date: Wed Aug 16 02:15:53 2023 +0530
audit: add space before parenthesis and around '=', "==", and '<'
Fixes following checkpatch.pl issue: ERROR: space required before the open parenthesis '(' ERROR: spaces required around that '=' ERROR: spaces required around that '<' ERROR: spaces required around that '=='
Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com> [PM: subject line tweaks] Signed-off-by: Paul Moore <paul@paul-moore.com>
-- paul-moore.com
| |