Messages in this thread | | | Date | Wed, 16 Aug 2023 15:17:00 +0200 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH] soc: kunpeng_hccs: fix some sparse warnings about incorrect type |
| |
On Tue, Aug 15, 2023, at 14:52, Huisong Li wrote: > @@ -199,8 +200,8 @@ static int hccs_pcc_cmd_send(struct hccs_dev *hdev, u8 cmd, > struct hccs_desc *desc) > { > struct hccs_mbox_client_info *cl_info = &hdev->cl_info; > - struct acpi_pcct_shared_memory *comm_base = cl_info->pcc_comm_addr; > - void *comm_space = (void *)(comm_base + 1); > + void __iomem *comm_space = (u8 *)cl_info->pcc_comm_addr + > + sizeof(struct acpi_pcct_shared_memory); > struct hccs_fw_inner_head *fw_inner_head; > struct acpi_pcct_shared_memory tmp = {0}; > u16 comm_space_size;
The cast still looks wrong, while both comm_space and ->pcc_comm_addr are __iomem pointers, casting to a non-__iomem u8 pointer should still produce that warning. I'd suggest casting to (u8 __iomem *) or (void __iomem *), I assume you still need a cast here to get the correct address.
Arnd
| |