Messages in this thread | | | From | "Sriranjani P" <> | Subject | RE: [PATCH v3 4/4] arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC | Date | Wed, 16 Aug 2023 11:56:57 +0530 |
| |
> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] > Sent: 15 August 2023 01:12 > To: Sriranjani P <sriranjani.p@samsung.com>; davem@davemloft.net; > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > conor+dt@kernel.org; richardcochran@gmail.com; > alexandre.torgue@foss.st.com; joabreu@synopsys.com; > mcoquelin.stm32@gmail.com; alim.akhtar@samsung.com; linux- > fsd@tesla.com; pankaj.dubey@samsung.com; swathi.ks@samsung.com; > ravi.patel@samsung.com > Cc: netdev@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-samsung-soc@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; Jayati Sahu <jayati.sahu@samsung.com> > Subject: Re: [PATCH v3 4/4] arm64: dts: fsd: Add Ethernet support for PERIC > Block of FSD SoC > > On 14/08/2023 21:41, Krzysztof Kozlowski wrote: > > On 14/08/2023 13:25, Sriranjani P wrote: > >> The FSD SoC contains two instances of Synopsys DWC QoS Ethernet IP, > >> one in > >> FSYS0 block and other in PERIC block. > >> > >> Adds device tree node for Ethernet in PERIC Block and enables the > >> same for FSD platform. > >> > >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > >> Signed-off-by: Jayati Sahu <jayati.sahu@samsung.com> > >> Signed-off-by: Swathi K S <swathi.ks@samsung.com> > >> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com> > >> --- > >> arch/arm64/boot/dts/tesla/fsd-evb.dts | 9 ++++ > >> arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 56 > ++++++++++++++++++++++ > >> arch/arm64/boot/dts/tesla/fsd.dtsi | 29 +++++++++++ > >> 3 files changed, 94 insertions(+) > > > > Looks duplicated. > > Ah, not, it's another block. > > My question whether this was tested remains...
I understand your concern. It was tested but just before posting I addressed one of earlier review comment of compatible and I missed to reflect it in all the patches. I will take care.
> > Best regards, > Krzysztof
| |