Messages in this thread | | | Date | Wed, 16 Aug 2023 14:46:34 +0200 | Subject | Re: [PATCH v15 1/2] thermal: loongson-2: add thermal management support | From | Daniel Lezcano <> |
| |
On 20/06/2023 03:29, Yinbo Zhu wrote: > This patch adds the support for Loongson-2 thermal sensor controller, > which can support maximum four sensor selectors that corresponding to four > sets of thermal control registers and one set of sampling register. The > sensor selector can selector a speific thermal sensor as temperature input. > The sampling register is used to obtain the temperature in real time, the > control register GATE field is used to set the threshold of high or low > temperature, when the input temperature is higher than the high temperature > threshold or lower than the low temperature threshold, an interrupt will > occur. > > Signed-off-by: zhanghongchen <zhanghongchen@loongson.cn> > Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> > ---
[ ... ]
> + if (devm_thermal_add_hwmon_sysfs(dev, tzd)) > + dev_warn(dev, "Failed to add hwmon sysfs attributes\n");
[ ... ]
This has been factored out by adding a message directly in devm_thermal_add_hwmon_sysfs(), so the test is not needed here neither the message.
However, these changes have been long enough on the mailing list and the result looks nice.
I can pick this patch and you provide a small patch on top. Or you send a V16 with this change. It is your call.
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |