lkml.org 
[lkml]   [2023]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:sched/eevdf] [sched/fair] e0c2ff903c: phoronix-test-suite.blogbench.Write.final_score -34.8% regression
On Mon, Aug 14, 2023 at 08:32:55PM +0200, Mike Galbraith wrote:

> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -875,6 +875,12 @@ static struct sched_entity *pick_eevdf(s
> if (curr && (!curr->on_rq || !entity_eligible(cfs_rq, curr)))
> curr = NULL;
>
> + /*
> + * Once selected, run the task to parity to avoid overscheduling.
> + */
> + if (sched_feat(RUN_TO_PARITY) && curr)
> + return curr;
> +
> while (node) {
> struct sched_entity *se = __node_2_se(node);
>

So I read it wrong last night... but I rather like this idea. But
there's something missing. When curr starts a new slice it should
probably do a full repick and not stick with it.

Let me poke at this a bit.. nice

\
 
 \ /
  Last update: 2023-08-16 14:38    [W:0.211 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site