| Date | Wed, 16 Aug 2023 13:27:38 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH v3 56/62] mmc: renesas_sdhi: Convert to platform remove callback returning void |
| |
On Thu, Jul 27, 2023 at 03:00:45PM +0800, Yangtao Li wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Yangtao Li <frank.li@vivo.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Builds fine, boots fine, rebind works:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[unhandled content-type:application/pgp-signature] |