Messages in this thread | | | Subject | Re: [PATCH bpf-next v5] libbpf: Expose API to consume one ring at a time | From | Hou Tao <> | Date | Wed, 16 Aug 2023 15:57:52 +0800 |
| |
Hi,
On 8/16/2023 3:22 PM, Adam Sindelar wrote: > On Fri, Jul 28, 2023 at 06:51:25PM +0800, Hou Tao wrote: > Hi, sorry for potentially dumb question, but should I do anything else > after someone acks it? This is a minor patch for a userland component, > but it's really helpful IMO - is anything preventing this getting merged > at this point?
According to BPF CI [0], the main reason that it was closed was due to the failure of test_progs_no_alu32 on s390x, but it seems the failure was due to BPF CI itself instead of the modification in the patchset, so I think resend v5 to BPF mail list will be enough. After the pass of BPF CI, I think the maintainer will merge it if there is no disagreement.
[0]: https://github.com/kernel-patches/bpf/actions/runs/5829217685/job/15808898814 > Thanks, > Adam > >> On 7/28/2023 5:33 PM, Adam Sindelar wrote: >>> We already provide ring_buffer__epoll_fd to enable use of external >>> polling systems. However, the only API available to consume the ring >>> buffer is ring_buffer__consume, which always checks all rings. When >>> polling for many events, this can be wasteful. >>> >>> Signed-off-by: Adam Sindelar <adam@wowsignal.io> >> Acked-by: Hou Tao <houtao1@huawei.com> >>
| |