lkml.org 
[lkml]   [2023]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [EXTERNAL] [PATCH] mm/thp: fix "mm: thp: kill __transhuge_page_enabled()"
> We have a out of tree driver that maps huge pages through a file handle and
> relies on -> huge_fault. It used to work in 5.19 kernels but 6.1 changed this
> behaviour.
>
> I don’t think reverting the earlier behaviour of fault_path for huge pages should
> impact kernel negatively.
>
> Do you think we can restore this earlier behaviour of kernel to allow page fault
> for huge pages via ->huge_fault.

That seems reasonable to me. I think using the existence of a
->huge_fault() handler as a predicate to return "true" makes sense to
me. The "normal" flow for file-backed memory along fault path still
needs to return "false", so that we correctly fallback to ->fault()
handler. Unless there are objections, I can do that in a v2.

\
 
 \ /
  Last update: 2023-08-16 23:49    [W:0.104 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site