Messages in this thread | | | Date | Wed, 16 Aug 2023 12:30:11 -0700 | From | Nathan Chancellor <> | Subject | Re: [tip: x86/urgent] x86/cpu: Clean up SRSO return thunk mess |
| |
On Wed, Aug 16, 2023 at 09:24:13PM +0200, Borislav Petkov wrote: > On Wed, Aug 16, 2023 at 11:58:39AM -0700, Nathan Chancellor wrote: > > but it obviously gets fixed by commit a3fd3ac0a605 ("x86/cpu: Rename > > srso_(.*)_alias to srso_alias_\1") so it is probably fine. I only > > noticed it because I cherry-picked the first five changes to my patched > > -next tree. > > Gah, and I meant to merge that hunk into the right one when fixing the > 32-bit builds.
Heh, fixups are always hard to get right across multiple patches, been there, done that...
> So how did you trigger it? You do builds of every patch? Because that's > the !CONFIG_CPU_SRSO case.
Just ARCH=i386 allmodconfig. CONFIG_CPU_SRSO depends on X86_64 so I guess that is how it got triggered. I did not build between every patch, just this one (since it should fix the runtime warning folks have been noticing) and the final one (as I reported earlier).
> Oh well, lemme rebase and fix it. > > Thx for letting me know.
No problem, hopefully most of the hard work around SRSO is behind us :)
Cheers, Nathan
| |