Messages in this thread Patch in this message | | | Date | Wed, 16 Aug 2023 12:21:31 -0700 | Subject | Re: [PATCH 1/2] media: v4l: usb: Use correct dependency for camera sensor drivers | From | Randy Dunlap <> |
| |
Hi Sakari,
On 8/16/23 06:35, Sakari Ailus wrote: > The Kconfig option that enables compiling camera sensor drivers is > VIDEO_CAMERA_SENSOR rather than MEDIA_CAMERA_SUPPORT as it was previously. > Fix this. > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Fixes: 7d3c7d2a2914 ("media: i2c: Add a camera sensor top level menu") > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > drivers/media/usb/em28xx/Kconfig | 4 ++-- > drivers/media/usb/go7007/Kconfig | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) >
This patch reduces the number of kconfig warnings from 4 to 2. I still see these (and these appear to be duplicates, so only one):
WARNING: unmet direct dependencies detected for VIDEO_OV7670 Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=y] && VIDEO_CAMERA_SENSOR [=n] Selected by [y]: - VIDEO_MMP_CAMERA [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && I2C [=y] && VIDEO_DEV [=y] && (ARCH_MMP || COMPILE_TEST [=y]) && COMMON_CLK [=y]
WARNING: unmet direct dependencies detected for VIDEO_OV7670 Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=y] && VIDEO_CAMERA_SENSOR [=n] Selected by [y]: - VIDEO_MMP_CAMERA [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && I2C [=y] && VIDEO_DEV [=y] && (ARCH_MMP || COMPILE_TEST [=y]) && COMMON_CLK [=y]
Thanks.
> diff --git a/drivers/media/usb/em28xx/Kconfig b/drivers/media/usb/em28xx/Kconfig > index b3c472b8c5a9..cb61fd6cc6c6 100644 > --- a/drivers/media/usb/em28xx/Kconfig > +++ b/drivers/media/usb/em28xx/Kconfig > @@ -12,8 +12,8 @@ config VIDEO_EM28XX_V4L2 > select VIDEO_SAA711X if MEDIA_SUBDRV_AUTOSELECT > select VIDEO_TVP5150 if MEDIA_SUBDRV_AUTOSELECT > select VIDEO_MSP3400 if MEDIA_SUBDRV_AUTOSELECT > - select VIDEO_MT9V011 if MEDIA_SUBDRV_AUTOSELECT && MEDIA_CAMERA_SUPPORT > - select VIDEO_OV2640 if MEDIA_SUBDRV_AUTOSELECT && MEDIA_CAMERA_SUPPORT > + select VIDEO_MT9V011 if MEDIA_SUBDRV_AUTOSELECT && VIDEO_CAMERA_SENSOR > + select VIDEO_OV2640 if MEDIA_SUBDRV_AUTOSELECT && VIDEO_CAMERA_SENSOR > help > This is a video4linux driver for Empia 28xx based TV cards. > > diff --git a/drivers/media/usb/go7007/Kconfig b/drivers/media/usb/go7007/Kconfig > index 4ff79940ad8d..b2a15d9fb1f3 100644 > --- a/drivers/media/usb/go7007/Kconfig > +++ b/drivers/media/usb/go7007/Kconfig > @@ -12,8 +12,8 @@ config VIDEO_GO7007 > select VIDEO_TW2804 if MEDIA_SUBDRV_AUTOSELECT > select VIDEO_TW9903 if MEDIA_SUBDRV_AUTOSELECT > select VIDEO_TW9906 if MEDIA_SUBDRV_AUTOSELECT > - select VIDEO_OV7640 if MEDIA_SUBDRV_AUTOSELECT && MEDIA_CAMERA_SUPPORT > select VIDEO_UDA1342 if MEDIA_SUBDRV_AUTOSELECT > + select VIDEO_OV7640 if MEDIA_SUBDRV_AUTOSELECT && VIDEO_CAMERA_SENSOR > help > This is a video4linux driver for the WIS GO7007 MPEG > encoder chip.
-- ~Randy
| |