Messages in this thread | | | Date | Wed, 16 Aug 2023 20:59:32 +0200 | Subject | Re: [PATCH RFC v3] mm: Proper document tail pages fields for folio | From | David Hildenbrand <> |
| |
>> do { >> xas_lock_irq(&xas); >> @@ -113,7 +114,6 @@ int add_to_swap_cache(struct folio *folio, swp_entry_t entry, >> if (shadowp) >> *shadowp = old; >> } >> - set_page_private(folio_page(folio, i), entry.val + i); >> xas_store(&xas, folio); >> xas_next(&xas); >> } >> @@ -154,9 +154,9 @@ void __delete_from_swap_cache(struct folio *folio, >> for (i = 0; i < nr; i++) { >> void *entry = xas_store(&xas, shadow); >> VM_BUG_ON_PAGE(entry != folio, entry); >> - set_page_private(folio_page(folio, i), 0); >> xas_next(&xas); >> } >> + folio->private = 0; > > I'd rather remove all direct reference to "private" for swap alongside, if > this would be the last spot (perhaps folio_set_swap_entry()).
Good idea, thanks!
-- Cheers,
David / dhildenb
| |