Messages in this thread | | | Subject | Re: [PATCH v2] i2c: stm32f7: Add atomic_xfer method to driver | From | Sean Nyekjaer <> | Date | Wed, 16 Aug 2023 09:22:48 +0200 |
| |
Hi Alain,
> On 16 Aug 2023, at 09.02, Sean Nyekjaer <sean@geanix.com> wrote: >
[ … ]
>>> _dev { >>> u32 dnf_dt; >>> u32 dnf; >>> struct stm32f7_i2c_alert *alert; >>> + bool atomic; >> >> I am wondering if this atomic really needs to be within the struct. >> It could well be given as last arg of stm32f7_i2c_xfer_core and >> stm32f7_i2c_xfer functions. > > Agree.
Scratch that… The atomic was included in the struct because it’s also used in the isr function, as the isr function is calling stm32f7_i2c_xfer_msg()
/Sean
| |