Messages in this thread | | | From | Ian Rogers <> | Date | Wed, 16 Aug 2023 11:36:39 -0700 | Subject | Re: [PATCH 1/1] perf tests trace+probe_vfs_getname.sh: Accept quotes surrounding the filename |
| |
On Tue, Aug 15, 2023 at 12:40 PM Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > With augmented_raw_syscalls transformed into a BPF skel made the output have a " > around the filenames, which is not what the old perf probe vfs_getname > method of obtaining filenames did, so accept the augmented way, with the > quotes. > > At this point probably removing all the logic for the vfs_getname method > is in order, will do it at some point. > > For now lets accept with/without quotes and make that test pass. > > Cc: Adrian Hunter <adrian.hunter@intel.com> > Cc: Ian Rogers <irogers@google.com> > Cc: Jiri Olsa <jolsa@kernel.org> > Cc: Namhyung Kim <namhyung@kernel.org> > Link: https://lore.kernel.org/lkml/ > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks, Ian
> --- > tools/perf/tests/shell/trace+probe_vfs_getname.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/tests/shell/trace+probe_vfs_getname.sh b/tools/perf/tests/shell/trace+probe_vfs_getname.sh > index 3697f054ce1903ac..4014487cf4d933da 100755 > --- a/tools/perf/tests/shell/trace+probe_vfs_getname.sh > +++ b/tools/perf/tests/shell/trace+probe_vfs_getname.sh > @@ -20,7 +20,7 @@ skip_if_no_perf_trace || exit 2 > trace_open_vfs_getname() { > evts="$(echo "$(perf list syscalls:sys_enter_open* 2>/dev/null | grep -E 'open(at)? ' | sed -r 's/.*sys_enter_([a-z]+) +\[.*$/\1/')" | sed ':a;N;s:\n:,:g')" > perf trace -e $evts touch $file 2>&1 | \ > - grep -E " +[0-9]+\.[0-9]+ +\( +[0-9]+\.[0-9]+ ms\): +touch/[0-9]+ open(at)?\((dfd: +CWD, +)?filename: +${file}, +flags: CREAT\|NOCTTY\|NONBLOCK\|WRONLY, +mode: +IRUGO\|IWUGO\) += +[0-9]+$" > + grep -E " +[0-9]+\.[0-9]+ +\( +[0-9]+\.[0-9]+ ms\): +touch/[0-9]+ open(at)?\((dfd: +CWD, +)?filename: +\"?${file}\"?, +flags: CREAT\|NOCTTY\|NONBLOCK\|WRONLY, +mode: +IRUGO\|IWUGO\) += +[0-9]+$" > } > > > -- > 2.41.0 >
| |