lkml.org 
[lkml]   [2023]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V1 2/2] phy: qcom-qmp-ufs: Add Phy Configuration support for SC7280
From
On 16.08.2023 20:12, Konrad Dybcio wrote:
> On 16.08.2023 17:48, Nitin Rawat wrote:
>> Add SC7280 specific register layout and table configs.
>>
>> Co-developed-by: Manish Pandey <quic_mapa@quicinc.com>
>> Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>
>> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
>> ---
> Looks very reasonable compared to what I can see downstream.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
I guess one nit I'd add is that having the compatible list sorted
alphanumerically would be a nice touch

Konrad

\
 
 \ /
  Last update: 2023-08-16 20:15    [W:0.037 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site