Messages in this thread Patch in this message | | | Date | Tue, 15 Aug 2023 14:43:20 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf evsel: Remove duplicate check for `field` in evsel__intval() |
| |
Em Tue, Aug 15, 2023 at 10:10:09PM +0000, Yang Jihong escreveu: > The `file` parameter in evsel__intval() is checked repeatedly, fix it. > > No functional change.
Thanks, applied.
- Arnaldo
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com> > --- > tools/perf/util/evsel.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index e41bc4d9925f..0c50c443d456 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -2827,9 +2827,6 @@ u64 evsel__intval(struct evsel *evsel, struct perf_sample *sample, const char *n > { > struct tep_format_field *field = evsel__field(evsel, name); > > - if (!field) > - return 0; > - > return field ? format_field__intval(field, sample, evsel->needs_swap) : 0; > } > #endif > -- > 2.39.2 >
--
- Arnaldo
| |