Messages in this thread | | | Date | Tue, 15 Aug 2023 18:55:45 +0200 | From | Marcus Folkesson <> | Subject | Re: [PATCH v5 4/6] iio: adc: mcp3911: fix indentation |
| |
On Tue, Aug 15, 2023 at 05:58:13PM +0300, Andy Shevchenko wrote: > On Mon, Aug 14, 2023 at 02:10:08PM +0200, Marcus Folkesson wrote: > > The file does not make use of indentation properly. > > > Fix that. > > I'm not sure this is anyhow a fix. Yet you may refer to the checkpatch > if it complains. > > ... > > This kind of change is preferred to be the last in the series or closer > to the end where no more code changed.
Checkpatch did never complain about the formatting, but I got a few comments during the review process about the formatting, so I went through the whole file to fix it once for all.
I do not think that it has to be the last patch in the series. All following patches has proper indentation. Pretty much the same as the simplification of spi->dev I think.
If there is no strong opinions about it I think I will leave it as is.
> > > -- > With Best Regards, > Andy Shevchenko > >
Best regards, Marcus Folkesson [unhandled content-type:application/pgp-signature] | |