lkml.org 
[lkml]   [2023]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 21/25] ASoC: dmaengine: Convert to generic PCM copy ops
On Tue, 15 Aug 2023 16:00:05 +0200,
Andy Shevchenko wrote:
>
> Can be compressed to a single conditional:
>
> if (is_playback && copy_from_iter(dma_ptr, bytes, buf) != bytes)

I prefer keeping the changes minimalistic in this kind of conversion
unless it becomes too ugly. Then it's more clearer what's actually
changed.


thanks,

Takashi

\
 
 \ /
  Last update: 2023-08-15 16:56    [W:0.065 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site