Messages in this thread | | | Date | Tue, 15 Aug 2023 16:55:24 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH 21/25] ASoC: dmaengine: Convert to generic PCM copy ops |
| |
On Tue, 15 Aug 2023 16:00:05 +0200, Andy Shevchenko wrote: > > Can be compressed to a single conditional: > > if (is_playback && copy_from_iter(dma_ptr, bytes, buf) != bytes)
I prefer keeping the changes minimalistic in this kind of conversion unless it becomes too ugly. Then it's more clearer what's actually changed.
thanks,
Takashi
| |