Messages in this thread | | | Subject | Re: [PATCH v5 2/2] pipe: use __pipe_{lock,unlock} instead of spinlock | From | Hongchen Zhang <> | Date | Tue, 15 Aug 2023 14:01:33 +0800 |
| |
On 2023/8/14 下午4:47, David Howells wrote: > Hongchen Zhang <zhanghongchen@loongson.cn> wrote: > >> - spin_lock_irq(&pipe->rd_wait.lock); >> + __pipe_lock(pipe); > > This mustn't sleep. post_one_notification() needs to be callable with a > spinlock held. Hi David, Where is the usage scenario for post_one_notification, or what usage scenarios will it be used in the future? IMO, it is not advisable for a debugging tool to affect the performance of an syscall. > > David >
-- Best Regards Hongchen Zhang
| |