lkml.org 
[lkml]   [2023]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] thermal: generic-adc: removed unneeded call to platform_set_drvdata()
On Mon, Aug 14, 2023 at 9:09 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>

> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/thermal/thermal-generic-adc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/thermal-generic-adc.c
> index f4f1a04f8c0f..1717e4a19dcb 100644
> --- a/drivers/thermal/thermal-generic-adc.c
> +++ b/drivers/thermal/thermal-generic-adc.c
> @@ -142,7 +142,6 @@ static int gadc_thermal_probe(struct platform_device *pdev)
> return ret;
>
> gti->dev = &pdev->dev;
> - platform_set_drvdata(pdev, gti);
>
> gti->tz_dev = devm_thermal_of_zone_register(&pdev->dev, 0, gti,
> &gadc_thermal_ops);
> --
> 2.34.1
>

\
 
 \ /
  Last update: 2023-08-15 13:53    [W:0.057 / U:23.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site