Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 15 Aug 2023 10:04:32 +0200 | Subject | Re: [PATCH 2/2] gpio: sim: simplify code with cleanup helpers |
| |
On Wed, Aug 9, 2023 at 3:14 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Use macros defined in linux/cleanup.h to automate resource lifetime > control in the gpio-simulator. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> (...) > - mutex_lock(&chip->lock); > + guard(mutex)(&chip->lock); (...) > - mutex_lock(&chip->lock); > - ret = !!test_bit(offset, chip->value_map); > - mutex_unlock(&chip->lock); > + scoped_guard(mutex, &chip->lock) > + ret = !!test_bit(offset, chip->value_map);
This is really neat. When I grep:ed around in linux-next this seemed like the first user of the scoped guards, so maybe Peter Z want to take a look? I bet there is other code using it coming for this next merge window as well, but this is really the first that will land in linux-next as it seems.
It looks good to me FWIW: Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |