Messages in this thread | | | Date | Wed, 16 Aug 2023 09:16:30 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH] cpufreq: cppc: Add missing error pointer check |
| |
On 16-08-23, 03:05, Liao Chang wrote: > The function cppc_freq_invariance_init() may failed to create > kworker_fie, make it more robust by checking the return value to prevent > an invalid pointer dereference in kthread_destroy_worker(), which called > from cppc_freq_invariance_exit(). > > Signed-off-by: Liao Chang <liaochang1@huawei.com> > --- > drivers/cpufreq/cppc_cpufreq.c | 21 ++++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-)
I think why it was designed this way was to make the driver work, without invariance support, in the worst case instead of just failing completely. The invariance thing is a good to have feature, but not really necessary and so failing probing the driver for that isn't worth it. We should print all error messages though.
-- viresh
| |