lkml.org 
[lkml]   [2023]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/9] mm/compaction: use correct list in move_freelist_{head}/{tail}
From


On 8/5/2023 7:07 PM, Kemeng Shi wrote:
> The freepage is chained with buddy_list in freelist head. Use buddy_list
> instead of lru to correct the list operation.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>

Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

> ---
> mm/compaction.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index ea61922a1619..513b1caeb4fa 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1395,8 +1395,8 @@ move_freelist_head(struct list_head *freelist, struct page *freepage)
> {
> LIST_HEAD(sublist);
>
> - if (!list_is_last(freelist, &freepage->lru)) {
> - list_cut_before(&sublist, freelist, &freepage->lru);
> + if (!list_is_last(freelist, &freepage->buddy_list)) {
> + list_cut_before(&sublist, freelist, &freepage->buddy_list);
> list_splice_tail(&sublist, freelist);
> }
> }
> @@ -1412,8 +1412,8 @@ move_freelist_tail(struct list_head *freelist, struct page *freepage)
> {
> LIST_HEAD(sublist);
>
> - if (!list_is_first(freelist, &freepage->lru)) {
> - list_cut_position(&sublist, freelist, &freepage->lru);
> + if (!list_is_first(freelist, &freepage->buddy_list)) {
> + list_cut_position(&sublist, freelist, &freepage->buddy_list);
> list_splice_tail(&sublist, freelist);
> }
> }

\
 
 \ /
  Last update: 2023-08-15 09:18    [W:0.566 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site