lkml.org 
[lkml]   [2023]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] drivers: usb: Removes use of assignment in if condition
On Wed, Aug 16, 2023 at 02:11:41AM +0530, Atul Kumar Pant wrote:
> This patch fixes following checkpatch.pl issue:
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> ---
> drivers/usb/core/devio.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> index e501a03d6c70..56899fed6bd4 100644
> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -2333,9 +2333,10 @@ static int proc_ioctl(struct usb_dev_state *ps, struct usbdevfs_ioctl *ctl)
> }
> }
>
> + intf = usb_ifnum_to_if(ps->dev, ctl->ifno);
> if (ps->dev->state != USB_STATE_CONFIGURED)
> retval = -EHOSTUNREACH;
> - else if (!(intf = usb_ifnum_to_if(ps->dev, ctl->ifno)))
> + else if (!intf)

Did you mean to change the logic here by doing the calculation always?
Does that change functionality?

The existing code is fine, running checkpatch on code outside of
drivers/staging/ or on new patches you are writing, is generally
discouraged as the code usually is older than checkpatch is :)

thanks,

greg k-h

\
 
 \ /
  Last update: 2023-08-15 23:08    [W:0.072 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site