Messages in this thread Patch in this message | | | Date | Mon, 14 Aug 2023 08:31:49 -0700 | Subject | Re: [PATCH -next] dmaengine: idxd: Remove unused declarations | From | Fenghua Yu <> |
| |
Hi, Haibing,
On 8/14/23 06:59, Yue Haibing wrote: > Commit c05257b5600b ("dmanegine: idxd: open code the dsa_drv registration") > removed idxd_{un}register_driver() but not the declarations.
Is "removed idxd_{un}register_driver() definitions" better?
> Commit 034b3290ba25 ("dmaengine: idxd: create idxd_device sub-driver") > declared idxd_{un}register_idxd_drv() but never implemented.
s/implemented/implemented it/
> Commit 8f47d1a5e545 ("dmaengine: idxd: connect idxd to dmaengine subsystem") > declared idxd_parse_completion_status() but never implemented.
s/implemented/implemented it/
> > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > --- > drivers/dma/idxd/idxd.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h > index 5428a2e1b1ec..05a83359def9 100644 > --- a/drivers/dma/idxd/idxd.h > +++ b/drivers/dma/idxd/idxd.h > @@ -651,8 +651,6 @@ int idxd_register_bus_type(void); > void idxd_unregister_bus_type(void); > int idxd_register_devices(struct idxd_device *idxd); > void idxd_unregister_devices(struct idxd_device *idxd); > -int idxd_register_driver(void); > -void idxd_unregister_driver(void); > void idxd_wqs_quiesce(struct idxd_device *idxd); > bool idxd_queue_int_handle_resubmit(struct idxd_desc *desc); > void multi_u64_to_bmap(unsigned long *bmap, u64 *val, int count); > @@ -664,8 +662,6 @@ void idxd_mask_error_interrupts(struct idxd_device *idxd); > void idxd_unmask_error_interrupts(struct idxd_device *idxd); > > /* device control */ > -int idxd_register_idxd_drv(void); > -void idxd_unregister_idxd_drv(void); > int idxd_device_drv_probe(struct idxd_dev *idxd_dev); > void idxd_device_drv_remove(struct idxd_dev *idxd_dev); > int drv_enable_wq(struct idxd_wq *wq); > @@ -710,7 +706,6 @@ int idxd_enqcmds(struct idxd_wq *wq, void __iomem *portal, const void *desc); > /* dmaengine */ > int idxd_register_dma_device(struct idxd_device *idxd); > void idxd_unregister_dma_device(struct idxd_device *idxd); > -void idxd_parse_completion_status(u8 status, enum dmaengine_tx_result *res); > void idxd_dma_complete_txd(struct idxd_desc *desc, > enum idxd_complete_type comp_type, bool free_desc); >
Other than the minor commit message changes, the code looks good to me.
Thanks.
-Fenghua
| |