Messages in this thread | | | Date | Mon, 14 Aug 2023 17:25:49 +0200 | From | Greg KH <> | Subject | Re: [RFC PATCH 0/7] Rust Socket abstractions |
| |
On Mon, Aug 14, 2023 at 11:22:55AM +0200, Michele Dalle Rive wrote: > This patch series is intended to create Rust abstractions for Sockets > and other fundamental network entities. > > Specifically, it was added: > - Ip address and Socket address wrappers (for `in_addr`, `in6_addr`, > `sockaddr_in`, `sockaddr_in6`, `sockaddr_storage`). > - Socket wrapper. > - Socket flags and options enums. > - TCP and UDP specific abstractions over the Rust Socket structure. > > This series is a RFC because I would appreciate some feedback about: > - The structure of the module: is the division of the files and modules > appropriate or should it be more or less fine-grained? > Also, should the `net` module export all the structures of its > submodules? I noticed that it is done in the standard library. > - Whether the documentation is comprehensive enough. > - A few other specific questions, written in the individual patches. > > I would greatly appreciate any kind of feedback or opinion. > I am pretty new to the patch/mailing list world, so please point out any > mistake I might make.
The best feedback is "who will use these new interfaces?" Without that, it's really hard to review a patchset as it's difficult to see how the bindings will be used, right?
thanks,
greg k-h
| |