Messages in this thread | | | From | Huibin Shi <> | Subject | RE: [PATCH] Add Silicom Platform Driver | Date | Mon, 14 Aug 2023 13:09:15 +0000 |
| |
-----Original Message----- From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck Sent: Thursday, August 10, 2023 2:01 PM To: Huibin Shi <henrys@silicom-usa.com>; Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Cc: tglx@linutronix.de; mingo@redhat.com; bp@alien8.de; dave.hansen@linux.intel.com; x86@kernel.org; hpa@zytor.com; hdegoede@redhat.com; markgross@kernel.org; jdelvare@suse.com; linux-kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; linux-hwmon@vger.kernel.org; hb_shi2003@yahoo.com; Wen Wang <wenw@silicom-usa.com> Subject: Re: [PATCH] Add Silicom Platform Driver
Caution: This is an external email. Please take care when clicking links or opening attachments.
On 8/10/23 10:48, Huibin Shi wrote: > Ilpo, > > See my comments below. > > Thanks. > Henry > ----Original Message----- > From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > Sent: Thursday, August 3, 2023 8:07 AM > To: Huibin Shi <henrys@silicom-usa.com> > Cc: tglx@linutronix.de; mingo@redhat.com; bp@alien8.de; > dave.hansen@linux.intel.com; x86@kernel.org; hpa@zytor.com; > hdegoede@redhat.com; markgross@kernel.org; jdelvare@suse.com; > linux@roeck-us.net; linux-kernel@vger.kernel.org; > platform-driver-x86@vger.kernel.org; linux-hwmon@vger.kernel.org; > hb_shi2003@yahoo.com; Wen Wang <wenw@silicom-usa.com> > Subject: RE: [PATCH] Add Silicom Platform Driver > > Caution: This is an external email. Please take care when clicking links or opening attachments. > > > On Fri, 28 Jul 2023, Huibin Shi wrote: > >> Ilpo, >> >> Thanks for the comments. See my comments below. >> >> Updated patch will be sent out later after review comments from other reviewer are addressed. >> >> Henry >> -----Original Message----- >> From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> >> Sent: Wednesday, July 19, 2023 8:13 AM >> To: Henry Shi <henryshi2018@gmail.com> >> Cc: hbshi69@hotmail.com; tglx@linutronix.de; mingo@redhat.com; >> bp@alien8.de; dave.hansen@linux.intel.com; x86@kernel.org; >> hpa@zytor.com; hdegoede@redhat.com; markgross@kernel.org; >> jdelvare@suse.com; linux@roeck-us.net; LKML >> <linux-kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org; >> linux-hwmon@vger.kernel.org; hb_shi2003@yahoo.com; Huibin Shi >> <henrys@silicom-usa.com>; Wen Wang <wenw@silicom-usa.com> >> Subject: Re: [PATCH] Add Silicom Platform Driver >> >> Caution: This is an external email. Please take care when clicking links or opening attachments. >> >> >> On Tue, 18 Jul 2023, Henry Shi wrote: >> >>> The Silicom platform (silicom-platform) Linux driver for Swisscom >>> Business Box (Swisscom BB) as well as Cordoba family products is a >>> software solution designed to facilitate the efficient management >>> and control of devices through the integration of various Linux >>> frameworks. This platform driver provides seamless support for >>> device management via the Linux LED framework, GPIO framework, >>> Hardware Monitoring (HWMON), and device attributes. The Silicom >>> platform driver's compatibility with these Linux frameworks allows >>> applications to access and control Cordoba family devices using >>> existing software that is compatible with these frameworks. This >>> compatibility simplifies the development process, reduces >>> dependencies on proprietary solutions, and promotes interoperability >>> with other Linux-based systems and software. >>> >>> Signed-off-by: Henry Shi <henryshi2018@gmail.com> >>> --- >>> drivers/platform/x86/Kconfig | 12 + >>> drivers/platform/x86/Makefile | 1 + >>> drivers/platform/x86/silicom-platform.c | 1123 >>> +++++++++++++++++++++++ >>> 3 files changed, 1136 insertions(+) create mode 100644 >>> drivers/platform/x86/silicom-platform.c >>> > >>> +void lock_io_modules(void) >>> +{ >>> + mutex_lock(&mec_io_mutex); >>> +} >>> +EXPORT_SYMBOL(lock_io_modules); >>> + >>> +void unlock_io_modules(void) >>> +{ >>> + mutex_unlock(&mec_io_mutex); >>> +} >>> +EXPORT_SYMBOL(unlock_io_modules); > > These are unused. > > Henry: This will be used by another Silicom driver, which source code is not pushed to kernel repository. >
Besides, those function names are _way_ too generic for public symbols, and even more so for exports.
Henry: Good point, will change the function name to some special names when EXPORT them.
Guenter
| |