Messages in this thread | | | From | Sai Krishna Gajula <> | Subject | Re: [net-next PATCH v2] octeontx2-pf: Use PTP HW timestamp counter atomic update feature | Date | Mon, 14 Aug 2023 11:33:57 +0000 |
| |
> -----Original Message----- > From: Jakub Kicinski <kuba@kernel.org> > Sent: Saturday, August 12, 2023 3:35 AM > To: Sai Krishna Gajula <saikrishnag@marvell.com> > Cc: davem@davemloft.net; edumazet@google.com; pabeni@redhat.com; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri > Goutham <sgoutham@marvell.com>; Geethasowjanya Akula > <gakula@marvell.com>; Subbaraya Sundeep Bhatta > <sbhatta@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>; > richardcochran@gmail.com; Naveen Mamindlapalli > <naveenm@marvell.com> > Subject: Re: [net-next PATCH v2] octeontx2-pf: Use PTP HW timestamp > counter atomic update feature > > On Fri, 11 Aug 2023 05:48:38 +0000 Sai Krishna Gajula wrote: > > > If you reorder the includes - maybe put them in alphabetical order? > > > > There are some structure definitions in rvu.h which are required in > > ptp.h. So, re-ordering in alphabetical order will give compilation > > issue. > > Headers should be self-contained. Such dependencies are hard to figure out > for people doing refactoring so it'd be best to clean that up.
Ack, will fix the dependencies and keep the headers in alphabetical order in V3 patch.
Thanks, Sai
| |