lkml.org 
[lkml]   [2023]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] qed: remove unused 'resp_size' calculation
On Mon, Aug 14, 2023 at 09:45:03AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Newer versions of clang warn about this variable being assigned but
> never used:
>
> drivers/net/ethernet/qlogic/qed/qed_vf.c:63:67: error: parameter 'resp_size' set but not used [-Werror,-Wunused-but-set-parameter]
>
> There is no indication in the git history on how this was ever
> meant to be used, so just remove the entire calculation and argument
> passing for it to avoid the warning.
>
> Fixes: 1408cc1fa48c5 ("qed: Introduce VFs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/qlogic/qed/qed_vf.c | 45 +++++++++---------------
> 1 file changed, 17 insertions(+), 28 deletions(-)
>

I don't think that Fixes tag is really needed here and title should be [PATCH
net] or [PATCH net-next].

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

\
 
 \ /
  Last update: 2023-08-14 12:14    [W:0.069 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site