Messages in this thread | | | Date | Mon, 14 Aug 2023 11:15:17 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH v2] hid-wiimote-debug.c: Drop error checking for debugfs_create_file |
| |
On Tue, 30 May 2023, Osama Muhammad wrote:
> This patch removes the error checking for debugfs_create_file > in hid-wiimote-debug.c.c. This is because the debugfs_create_file() > does not return NULL but an ERR_PTR after an error. > The DebugFS kernel API is developed in a way that the > caller can safely ignore the errors that occur during > the creation of DebugFS nodes.The debugfs Api handles > it gracefully. The check is unnecessary. > > Link to the comment above debugfs_create_file: > https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L451 > > Signed-off-by: Osama Muhammad <osmtendev@gmail.com> > > --- > changes since v1 > -In v1 the IS_ERR was used for error checking which is dropped now.
Now applied, sorry for the delay.
-- Jiri Kosina SUSE Labs
| |