lkml.org 
[lkml]   [2023]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller


On Mon, Aug 14 2023 at 10:08:38 AM +02:00:00, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> On 14/08/2023 08:38, Martin Botka wrote:
>> Add binding for the SID controller found in H616 SoC
>>
>> Signed-off-by: Martin Botka <martin.botka@somainline.org>
>> ---
>>
>> Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
>> | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
>> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
>> index 296001e7f498..2ec0a1b8f803 100644
>> ---
>> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
>> +++
>> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
>> @@ -27,6 +27,7 @@ properties:
>> - const: allwinner,sun50i-a64-sid
>> - const: allwinner,sun50i-h5-sid
>> - const: allwinner,sun50i-h6-sid
>> + - const: allwinner,sun50i-h616-sid
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> Best regards,
> Krzysztof
>
Yea completely forgot. Sorry for that.

Will send v3 tomorrow with proper binding patch using items with enums


\
 
 \ /
  Last update: 2023-08-14 10:25    [W:0.049 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site