Messages in this thread | | | Date | Mon, 14 Aug 2023 18:33:03 -0500 | Subject | Re: [PATCH] cpupower: Fix querying boost support for amd-pstate-epp mode | From | "Limonciello, Mario" <> |
| |
On 8/14/2023 6:22 PM, Shuah Khan wrote: > On 8/14/23 15:50, Limonciello, Mario wrote: >> >> >> On 8/14/2023 4:28 PM, Shuah Khan wrote: >>> On 8/13/23 22:14, Huang Rui wrote: >>>> On Sat, Aug 12, 2023 at 05:35:01AM +0800, Limonciello, Mario wrote: >>>>> When running in active mode the driver for amd-pstate has -epp >>>>> appended. >>>>> This throws off amd-pstate detection. >>>>> >>>>> To detect amd-pstate look for the prefix instead. >>>>> >>>>> Fixes: ffa5096a7c33 ("cpufreq: amd-pstate: implement Pstate EPP >>>>> support for the AMD processors") >>>>> Reported-by: chenhq2005@gmail.com >>>>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217755 >>>>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> >>>> >>>> Acked-by: Huang Rui <ray.huang@amd.com> >>>> >>> >>> This patch doesn't apply on top of cpupower latest: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git coupower >>> >>> Please rebase and send it. >>> >>> thanks, >>> -- Shuah >>> >> >> It looks like a variation of it is already in your tree as: >> >> a1cf97c2d43ae ("cpupower: Recognise amd-pstate active mode driver") >> >> Considering it was also reported to a kernel bugzilla, perhaps this >> should be considered for fixes? > > If it is already fixed, there is no need to revert and apply your fix. > Please close the bugzilla bug as fixed with the above commit.
Sorry I was unclear. My suggestion was that perhaps a1cf97c2d43ae should be considered alone for 6.5-rc7 instead of waiting for 6.6-rc1 as it fixes the Bugzilla issue. Otherwise we should wait until it's in Linus' tree for 6.6-rc1 to close the Bugzilla.
| |