Messages in this thread | | | Date | Mon, 14 Aug 2023 09:16:21 +0200 | From | Willy Tarreau <> | Subject | Re: [PATCH v2 5/7] selftests/nolibc: customize CROSS_COMPILE for all architectures |
| |
On Sun, Aug 13, 2023 at 06:18:05PM +0800, Zhangjin Wu wrote: > > Given that we don't support mips64, I'd suggest to ust mips-linux- > > instead here for now. That doesn't seem right to ask users to > > download a toolchain for a different architecture than the one > > supported just because we can adapt to it. > > > > Agree very much, and the one below from patch 7/7 [1]: > > +CROSS_COMPILE_arm64 ?= aarch64-linux- aarch64-linux-gnu- > +CROSS_COMPILE_arm ?= arm-linux-gnueabi- arm-none-eabi- > +CROSS_COMPILE_mips ?= mips64-linux- mips64el-linux-gnuabi64- > > It should be: > > +CROSS_COMPILE_mips ?= mips-linux- mips-linux-gnu-gcc > > And if necessary, the mips64-linux- line in the commit message of [1] should be > corrected too.
I just did that (and fixed mips-linux-gnu- instead of mips-linux-gnu-gcc above).
Thanks, Willy
| |