lkml.org 
[lkml]   [2023]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: vme_user: fix check blank lines not necessary
On Mon, Aug 14, 2023 at 04:33:11PM -0300, Alexon Oliveira wrote:
> Fixed all CHECK: Blank lines aren't necessary after an open brace '{'
> and CHECK: Blank lines aren't necessary before a close brace '}'
> as reported by checkpatch to adhere to the Linux kernel
> coding-style guidelines.
>
> Signed-off-by: Alexon Oliveira <alexondunkan@gmail.com>
> ---
> drivers/staging/vme_user/vme.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
> index 5eb0d780c77f..c7c50406c199 100644
> --- a/drivers/staging/vme_user/vme.c
> +++ b/drivers/staging/vme_user/vme.c
> @@ -308,7 +308,6 @@ struct vme_resource *vme_slave_request(struct vme_dev *vdev, u32 address,
> if (((slave_image->address_attr & address) == address) &&
> ((slave_image->cycle_attr & cycle) == cycle) &&
> (slave_image->locked == 0)) {
> -
> slave_image->locked = 1;
> mutex_unlock(&slave_image->mtx);
> allocated_image = slave_image;
> @@ -510,7 +509,6 @@ struct vme_resource *vme_master_request(struct vme_dev *vdev, u32 address,
> ((master_image->cycle_attr & cycle) == cycle) &&
> ((master_image->width_attr & dwidth) == dwidth) &&
> (master_image->locked == 0)) {
> -
> master_image->locked = 1;
> spin_unlock(&master_image->lock);
> allocated_image = master_image;
> @@ -682,10 +680,8 @@ ssize_t vme_master_read(struct vme_resource *resource, void *buf, size_t count,
> count = length - offset;
>
> return bridge->master_read(image, buf, count, offset);
> -
> }
> EXPORT_SYMBOL(vme_master_read);
> -

This line needs to be there, checkpatch should not have complained about
it.

thanks,

greg k-h

\
 
 \ /
  Last update: 2023-08-14 22:19    [W:0.036 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site