Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 14 Aug 2023 20:22:28 +0200 | Subject | Re: [PATCH] powerpc: Make virt_to_pfn() a static inline |
| |
On Mon, Aug 14, 2023 at 2:37 PM Michael Ellerman <mpe@ellerman.id.au> wrote:
> > +static inline const void *pfn_to_kaddr(unsigned long pfn) > > +{ > > + return (const void *)(((unsigned long)__va(pfn)) << PAGE_SHIFT); > > Any reason to do it this way rather than: > > + return __va(pfn << PAGE_SHIFT); > > Seems to be equivalent and much cleaner?
I was afraid of changing the semantic in the original macro which converts to a virtual address before shifting, instead of shifting first, but you're right, I'm too cautious. I'll propose the elegant solution from you & Christophe instead!
Yours, Linus Walleij
| |