lkml.org 
[lkml]   [2023]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/7] selftests/resctrl: Correct benchmark command help
    From
    Hi Ilpo,

    On 8/8/2023 2:16 AM, Ilpo Järvinen wrote:
    > Benchmark command must be the last argument because it consumes all the
    > remaining arguments but help misleadingly shows it as the first
    > argument. The benchmark command is also shown in quotes but it does not
    > match with the code.
    >
    > Correct -b argument place in the help message and remove the quotes.
    > Tweak also how the options are presented by using ... notation.
    >
    > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
    > ---
    > tools/testing/selftests/resctrl/resctrl_tests.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
    > index eef9e02516ad..559868b16079 100644
    > --- a/tools/testing/selftests/resctrl/resctrl_tests.c
    > +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
    > @@ -52,7 +52,7 @@ int get_vendor(void)
    >
    > static void cmd_help(void)
    > {
    > - printf("usage: resctrl_tests [-h] [-b \"benchmark_cmd [options]\"] [-t test list] [-n no_of_bits]\n");
    > + printf("usage: resctrl_tests [-h] [-t test list] [-n no_of_bits] [-b benchmark_cmd [option]...]\n");
    > printf("\t-b benchmark_cmd [options]: run specified benchmark for MBM, MBA and CMT\n");

    Considering it was documented goal of patch to use "..." notation, should
    it be done consistently by changing above line also?

    > printf("\t default benchmark is builtin fill_buf\n");
    > printf("\t-t test list: run tests specified in the test list, ");

    Reinette

    \
     
     \ /
      Last update: 2023-08-14 19:51    [W:7.519 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site