Messages in this thread | | | Subject | Re: [PATCH] LoongArch: Remove noreturn attribute for die() | From | Tiezhu Yang <> | Date | Mon, 14 Aug 2023 11:06:02 +0800 |
| |
On 08/01/2023 02:33 PM, Tiezhu Yang wrote: > If notify_die() returns NOTIFY_STOP, there is no need to call > make_task_dead(), we can remove noreturn attribute for die(), > this is similar with arm64, riscv and csky. > > While at it, modify the die() declaration in ptrace.h to fix > the following checkpatch warnings: > > WARNING: function definition argument 'const char *' should also have an identifier name > WARNING: function definition argument 'struct pt_regs *' should also have an identifier name > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> > --- > arch/loongarch/include/asm/ptrace.h | 2 +- > arch/loongarch/kernel/traps.c | 12 ++++++------ > 2 files changed, 7 insertions(+), 7 deletions(-)
There is a similar patch for MIPS, here is the discussion, https://lore.kernel.org/all/alpine.DEB.2.21.2308132148500.8596@angie.orcam.me.uk/
As suggested by Maciej W. Rozycki, I will update the commit message and split it into two patches, then I will send v2 later.
Thanks, Tiezhu
| |