Messages in this thread | | | Date | Fri, 11 Aug 2023 17:44:55 +0100 | Subject | Re: [PATCH net-next] net: phy: mediatek-ge-soc: support PHY LEDs | From | Vadim Fedorenko <> |
| |
On 11/08/2023 17:39, Andrew Lunn wrote: >>> + /* Only now setup pinctrl to avoid bogus blinking */ >>> + pinctrl = devm_pinctrl_get_select(&phydev->mdio.dev, "gbe-led"); >> >> This function gets reference on phydev->mdio.dev, but there is no code >> to release it. It looks like a leak which will prevent module unload, >> but I don't have hardware now to prove it. > > Since it is a devm_ function, it should get released when the device > is destroyed. Or am i missing something? >
Oh, got it. Yeah, resource managed code needs no explicit *put() calls. Thanks for the clarification.
| |