lkml.org 
[lkml]   [2023]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] net: phy: mediatek-ge-soc: support PHY LEDs
From
On 11/08/2023 17:39, Andrew Lunn wrote:
>>> + /* Only now setup pinctrl to avoid bogus blinking */
>>> + pinctrl = devm_pinctrl_get_select(&phydev->mdio.dev, "gbe-led");
>>
>> This function gets reference on phydev->mdio.dev, but there is no code
>> to release it. It looks like a leak which will prevent module unload,
>> but I don't have hardware now to prove it.
>
> Since it is a devm_ function, it should get released when the device
> is destroyed. Or am i missing something?
>

Oh, got it. Yeah, resource managed code needs no explicit *put() calls.
Thanks for the clarification.

\
 
 \ /
  Last update: 2023-08-11 18:46    [W:0.193 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site