Messages in this thread | | | Date | Fri, 11 Aug 2023 18:31:13 +0200 | Subject | Re: [PATCH] drm/msm/a690: Switch to a660_gmu.bin | From | Konrad Dybcio <> |
| |
On 11.08.2023 18:21, Rob Clark wrote: > On Fri, Aug 11, 2023 at 9:11 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >> >> On 11.08.2023 18:09, Rob Clark wrote: >>> On Fri, Aug 11, 2023 at 9:05 AM Rob Clark <robdclark@gmail.com> wrote: >>>> >>>> From: Rob Clark <robdclark@chromium.org> >>>> >>>> There isn't actually a a690_gmu.bin. But it appears that the normal >>>> a660_gmu.bin works fine. Normally all the devices within a sub- >>>> generation (or "family") will use the same fw, and a690 is in the a660 >>>> family. >>>> >>> >>> possibly this could be considered as: >>> >>> Fixes: 5e7665b5e484 ("drm/msm/adreno: Add Adreno A690 support") >> For a lack of a better response, "meh" > > It would help route the change back to 6.4.y so we can stop explaining > to folks that they should create a symlink ;-) Ok fair!
> >> Other than that: >> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> >> Perhaps we could take this further and do something like >> >> if (failed to load gmu fw) >> try loading "gmu.bin" > > that (loading random fw) sounds like a bad idea.. plus gmu.bin doesn't exist I guess we still should hear from Qualcomm on this one, but I do believe that "aXYZ_gmu.bin" is really "gmu firmware, tagged at aXYZ release". They're even versioned and adreno-gpulist.h downstream contains the minimum version for each SKU.
Konrad
| |