Messages in this thread | | | Date | Fri, 11 Aug 2023 08:21:33 +0200 | Subject | Re: [PATCH v2 2/6] bitmap: replace _reg_op(REG_OP_ALLOC) with bitmap_set() | From | Rasmus Villemoes <> |
| |
On 11/08/2023 02.57, Yury Norov wrote: > _reg_op(REG_OP_ALLOC) duplicates bitmap_set(). Fix it. > > Signed-off-by: Yury Norov <yury.norov@gmail.com> > --- > lib/bitmap.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/bitmap.c b/lib/bitmap.c > index 3a589016f5e0..c9afe704fe4b 100644 > --- a/lib/bitmap.c > +++ b/lib/bitmap.c > @@ -1352,9 +1352,12 @@ EXPORT_SYMBOL(bitmap_release_region); > */ > int bitmap_allocate_region(unsigned long *bitmap, unsigned int pos, int order) > { > + unsigned int nbits = pos + BIT(order); > +
That really doesn't sound right. Have you added self-tests for these functions first and then used those to catch regressions?
Rasmus
| |