Messages in this thread | | | From | Alexandru Ardelean <> | Date | Fri, 11 Aug 2023 08:55:11 +0300 | Subject | Re: [PATCH] thermal: broadcom: sr-thermal: removed call to platform_set_drvdata() |
| |
On Thu, Aug 10, 2023 at 2:13 PM Andrei Coardos <aboutphysycs@gmail.com> wrote: > > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. >
I had to take a look over how "thermal_zone_device_priv()" works, and it looks like it has nothing to do with the platform_set_drvdata() / dev_set_drvdata() / dev->driver_data stuff. It defines it's own `devdata` pointer. Though, it looks like "thermal_zone_device_priv()" could potentially be converted to use "dev->driver_data" But that requires a bit of going through all drivers to convert them.
Anyway, for this:
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > --- > drivers/thermal/broadcom/sr-thermal.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/thermal/broadcom/sr-thermal.c b/drivers/thermal/broadcom/sr-thermal.c > index 747915890022..9a29dfd4c7fe 100644 > --- a/drivers/thermal/broadcom/sr-thermal.c > +++ b/drivers/thermal/broadcom/sr-thermal.c > @@ -91,7 +91,6 @@ static int sr_thermal_probe(struct platform_device *pdev) > > dev_dbg(dev, "thermal sensor %d registered\n", i); > } > - platform_set_drvdata(pdev, sr_thermal); > > return 0; > } > -- > 2.34.1 >
| |