Messages in this thread | | | From | Gowthami Thiagarajan <> | Subject | RE: [EXT] Re: [PATCH 4/6] dt-bindings: perf: marvell: Add YAML schemas for Marvell Odyssey LLC-TAD pmu | Date | Sat, 12 Aug 2023 03:33:03 +0000 |
| |
Hi,
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Sunday, July 2, 2023 2:56 PM > To: Gowthami Thiagarajan <gthiagarajan@marvell.com>; will@kernel.org; mark.rutland@arm.com; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Cc: Sunil Kovvuri Goutham <sgoutham@marvell.com>; Bharat Bhushan <bbhushan2@marvell.com>; George > Cherian <gcherian@marvell.com>; Linu Cherian <lcherian@marvell.com> > Subject: [EXT] Re: [PATCH 4/6] dt-bindings: perf: marvell: Add YAML schemas for Marvell Odyssey LLC- > TAD pmu > > External Email > > ---------------------------------------------------------------------- > On 30/06/2023 14:03, Gowthami Thiagarajan wrote: > > Add device tree bindings for Marvell Odyssey LLC-TAD performance > > monitor unit > > > > Signed-off-by: Gowthami Thiagarajan <gthiagarajan@marvell.com> > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > You missed at least DT list (maybe more), so this won't be tested by our > tools. Performing review on untested code might be a waste of time, thus > I will skip this patch entirely till you follow the process allowing the > patch to be tested. > > Please kindly resend and include all necessary To/Cc entries.
Missed sending to DT list. Will add everyone while resending.
> > > --- > > .../bindings/perf/marvell-odyssey-tad.yaml | 63 +++++++++++++++++++ > > 1 file changed, 63 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml > > > > diff --git a/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml > b/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml > > new file mode 100644 > > index 000000000000..139567166f77 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml > > Filename does not match compatible.
Ack.
> > > > > +examples: > > + - | > > + > > + tad { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + tad_pmu@80000000 { > > Node names should be generic. See also explanation and list of examples > in DT specification: > https://urldefense.proofpoint.com/v2/url?u=https-3A__devicetree- > 2Dspecification.readthedocs.io_en_latest_chapter2-2Ddevicetree-2Dbasics.html-23generic-2Dnames- > 2Drecommendation&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=jXyDe1pTHpmFH9abKZ66HpyuWJquipUlbI9yktcgBgU&m=GdU > qi5f4jgPpB5WqFNmUoZBzc3eljzT7CbdkU7I2c2GJn6OrVE5DUNFL2qeL_k05&s=kjtFmv_ypTnmDrZqOm7nTET-- > ZCfPMWoyFBAQZVd7J8&e=
Ack.
> > > + compatible = "marvell,odyssey-tad-pmu"; > > + reg = <0x87E2 0x2B030000 0x0 0x1000>; > > lowercase hex
Ack. Will make the changes in the next version.
-Thanks, Gowthami > > Best regards, > Krzysztof
| |