Messages in this thread | | | Date | Fri, 11 Aug 2023 16:40:01 -0700 | Subject | Re: [PATCH] net: phy: broadcom: stub c45 read/write for 54810 | From | Florian Fainelli <> |
| |
On 8/11/2023 4:29 PM, Justin Chen wrote: > The 54810 does not support c45. The mmd_phy_indirect accesses return > arbirtary values leading to odd behavior like saying it supports EEE > when it doesn't. We also see that reading/writing these non-existent > MMD registers leads to phy instability in some cases. > > Signed-off-by: Justin Chen <justin.chen@broadcom.com>
Thanks for submitting this fix, I would be tempted to slap a:
Fixes: b14995ac2527 ("net: phy: broadcom: Add BCM54810 PHY entry")
so we get it back ported to stable trees where appropriate. It is not clear whether we should return -EINVAL vs. -EOPNOTSUPP which may more clearly indicate the inability to support MMD registers? -- Florian [unhandled content-type:application/pkcs7-signature]
| |