Messages in this thread | | | Date | Thu, 10 Aug 2023 17:49:29 +0200 | From | Greg KH <> | Subject | Re: [PATCH v2] media: vcodec: Fix potential array out-of-bounds in encoder queue_setup |
| |
On Thu, Aug 10, 2023 at 12:12:39PM +0300, Eugen Hristev wrote: > Hi Wei, > > On 8/10/23 11:23, Wei Chen wrote: > > variable *nplanes is provided by user via system call argument. The > > possible value of q_data->fmt->num_planes is 1-3, while the value > > of *nplanes can be 1-8. The array access by index i can cause array > > out-of-bounds. > > > > Fix this bug by checking *nplanes against the array size. > > > > Fixes: 4e855a6efa54 ("[media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver") > > Signed-off-by: Wei Chen <harperchen1110@gmail.com> > > Cc: stable@vger.kernel.org > > --- > > Changes in v2: > > - Add Fixes tag and CC stable email address > I guess stable needs to be added by the maintainer, not by the submitter
It's easiest if it is added by the submitter, makes the maintainer's job much easier.
thanks,
greg k-h
| |