Messages in this thread | | | Date | Thu, 10 Aug 2023 16:31:42 +0200 | From | Marcus Folkesson <> | Subject | Re: [PATCH v4 4/4] iio: adc: mcp3911: add support for the whole MCP39xx family |
| |
On Thu, Aug 10, 2023 at 04:44:20PM +0300, Andy Shevchenko wrote: > On Wed, Aug 09, 2023 at 08:14:54PM +0200, Krzysztof Kozlowski wrote: > > On 09/08/2023 20:02, Jonathan Cameron wrote: > > > On Wed, 9 Aug 2023 08:41:05 +0200 > > > Marcus Folkesson <marcus.folkesson@gmail.com> wrote: > > ... > > > >>> Inconsistent macro implementation, i.e. you need to use (x). > > >> > > >> Sorry, I do not get you > > In other macros you avoid ambiguity of the parameter, so they can be evaluated > properly, and not here.
Hrmf, I missed that I had asked about this before I sent out v5. Such a shame.
I got you now, thanks.
I agree that maybe it should be 'ch' instead. Already existing macros for channel and offcal use 'x' though, so in that case should be changed as well.
#define MCP3911_CHANNEL(x) (MCP3911_REG_CHANNEL0 + x * 3) #define MCP3911_OFFCAL(x) (MCP3911_REG_OFFCAL_CH0 + x * 6)
[...]
> > See (1) above ? > > -- > With Best Regards, > Andy Shevchenko > >
Best regards, Marcus Folkesson [unhandled content-type:application/pgp-signature] | |