Messages in this thread | | | Date | Thu, 10 Aug 2023 10:43:33 +0100 | From | Will Deacon <> | Subject | Re: [PATCH v5 2/9] iommu/arm-smmu-v3: Replace s1_cfg with cdtab_cfg |
| |
On Thu, Aug 10, 2023 at 05:33:53PM +0800, Michael Shavit wrote: > > > > Sounds a lot like the existing s1fmt field. Can we keep it? > > > > > > If you are OK with the dead code, I don't object. But let's put it in > > > the struct arm_smmu_ctx_desc_cfg. > > > > Ok, we have a deal! > > What dead code? Is the deal here that we keep the field, but still > infer the value to write from (cd_table->l1_desc == null) in > arm_smmu_write_strtab_ent??
Keep the field and write it directly when populating the ste (i.e. don't infer anything), but the field moves into 'struct arm_smmu_ctx_desc_cfg'.
Will
| |